公司工作遇到的一个问题,thrift版本是0.9.1
FrameBuffer为AbstractNonblockingServer类的内部类,TThreadedSelectorServer继承了AbstractNonblockingServer:
通过研究代码,发现FrameBuffer的read方法的代码中有如下片段,
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 |
<code class = "hljs kotlin" > <span class = "hljs-comment" > // pull out the frame size as an integer. int frameSize = buffer_.getInt(<span class = "hljs-number" > 0 ); <span class = "hljs-keyword" > if (frameSize <= <span class = "hljs-number" > 0 ) { LOGGER.error(<span class = "hljs-string" > "Read an invalid frame size of " + frameSize + <span class = "hljs-string" > ". Are you using TFramedTransport on the client side?" ); <span class = "hljs-keyword" > return <span class = "hljs-literal" > false ; } <span class = "hljs-comment" > // if this frame will always be too large for this server, log the <span class = "hljs-comment" > // error and close the connection. <span class = "hljs-keyword" > if (frameSize > MAX_READ_BUFFER_BYTES) { LOGGER.error(<span class = "hljs-string" > "Read a frame size of " + frameSize + <span class = "hljs-string" > ", which is bigger than the maximum allowable buffer size for ALL connections." ); <span class = "hljs-keyword" > return <span class = "hljs-literal" > false ; }</span></span></span></span></span></span></span></span></span></span></span></span></span></span></span></code> |
MAX_READ_BUFFER_BYTES这个值即为对读取的包的长度限制,为AbstractNonblockingServer类的属性,其值又取自内部类AbstractNonblockingServerArgs的maxReadBufferBytes属性,默认值为long型的最大值;
即只要修改maxReadBufferBytes的值就可以起到限制的作用,修改服务启动的代码如下:
1 2 3 4 5 6 7 8 9 10 11 12 |
<code class = "hljs actionscript" >TThreadedSelectorServer.Args args = <span class = "hljs-keyword" > new TThreadedSelectorServer.Args(transport).processor( processor).workerThreads(<span class = "hljs-keyword" > this .serverWorkerThreads); <span class = "hljs-comment" > // The maximum amount of memory we will allocate to client IO buffers at a time. <span class = "hljs-comment" > // set 1MB. args.maxReadBufferBytes = <span class = "hljs-number" > 1024 * <span class = "hljs-number" >1024L; server = <span class = "hljs-keyword" > new TThreadedSelectorServer(args); server.setServerEventHandler(<span class = "hljs-keyword" > new DataIfaceServerEvent()); LOG.info(<span class = "hljs-string" > "DataIfaceServer start, port={}." , <span class = "hljs-keyword" > this .serverPort); server.serve();</span></span></span></span></span></span></span></span></span></span></code> |
args.maxReadBufferBytes = 1024 * 1024L; --设置为1M
通过对我的thrift的服务进行抓包调研,我的方法调用请求数据包没有超过200字节的,所以1M的长度限制是足够了。
通过测试如上的修改没有问题,并且对服务继续发送http get请求不会导致直接内存增加。并且报出错误日志:
Read a frame size of XXX, which is bigger than the maximum allowable buffer size for ALL connections.
至此问题解决;