Software engineering 4. twinning review

First, I am a member of blog twinning link address: https://www.cnblogs.com/delephine/p/11716046.html

Second, the four members of the twinning project operation code review results table:

section	content	Zhang Ying Review	Wang Xiang month Review
1, Overview 　 section	(1) comply with the code requirements and specifications do	✔
	If (2) Code thoughtful design
	How (3) code readability
	(4) the code easier to maintain it
	(5) Each line of code is executed and checked yet
2, the code Design Specification	Whether or not (1) comply with design patterns Design
	(2) Have a hard-coded or strings / numbers, etc. present
	(3) whether a platform-dependent effects of transplantation
	(4) the developers added a new feature / function similar if you can use an existing debug
	(5) whether the dead code can be deleted
3, Code Specification	Compliance with code standards and style it
4, concrete Code section	(1) the presence or absence of error processing for calling an external function, check the return value or exception handling
	(2) whether there is an error parameter passing, a string of characters in length or a byte, the count is zero or 1
	(3) boundary conditions, switch branching, looping infinite loop
	(4) whether the assertion (Assert) to ensure that we believe have the same conditions are met
	(5) For the application to release resources for leaks and optimize space
	(6) less than or absence of the data structure element
5, performance	How to (1) how the code worst case performance
	(2) Code (especially cyclic) has no optimization
	(3) whether the system and the network calls a timeout, how to deal with
6, readability	How to code readability, there were enough comments
7, testability	If the code needs to be updated or create a new unit test

 

Third, the pair programming (by comparison selected Wang Xiang month project began to improve for the members of the foundation)

       1, the basic coding specification

　　　　(1) Notes Specification

　　　　　　1. Function block denoted

　　　　　　2. Explain the role of a simple variable named

　　　　(2) variable naming

　　　　　　Use more English words

        2, description of the programming experience junction

　　　　1. Zhang Ying feel:

　　　　2. Wang Xiang feelings month:

        3, twinning scene photos

Fourth, the twinning projects Programming

　　1, github connection address

　　2, description (at improvement)

　　　　1. Modify the code specifications and design specifications

　　　　　　(A) part of the variable name defined improved

　　　　　　（b）删除了多余数组
　　　　2.成项目增加的需求
　　　　　　（a）增加了数据异常处理问题，如在输入题目生成范围的数据时，输入了“abc“等字符数据，程序将退出/默认忽视当前功能。
　　　　　　（b）增大算式生成数的范围，改为long型。超出将退出。