javafx canvas draw compared to java.awt.graphics2d draw

Yupp :

I want to display a relative long diagram. I used to work with javafx canvas, but sometimes I get a buffer overflow exception, when there are to many values drawn. I was looking for a different approach and found a way to draw a diagram with java.awt.graphics2d. The advantage with graphics2d is that the performance improved and I don't get an exception. The disadvantage is the quality of the diagram. With graphics2d the diagram doesn't look as smooth as the diagram in a canvas in javafx.

Here a two test application (one with javafx canvas and one with java.awt.graphics2d) where a sine wave is drawn.

How can I improve the quality of the graphics2d example, so that it looks like the canvas example? Or is there a different approach that I haven't thought of that would solve my problem?

Canvas Example

public class CanvasDraw extends Application
{
    private static final int PANEL_WIDTH = 400, PANEL_HEIGHT = 100;


    public static void main(String[] args)
    {
        launch(args);
    }


    @Override
    public void start(Stage stage)
    {
        stage.setTitle("CanvasDraw");
        StackPane root = new StackPane();
        Scene scene = new Scene(root);
        root.getChildren().add(createCanvas());
        stage.setScene(scene);
        stage.show();
    }


    private Canvas createCanvas()
    {
        Canvas canvas = new Canvas(PANEL_WIDTH, PANEL_HEIGHT);
        GraphicsContext gc = canvas.getGraphicsContext2D();
        drawSinus(gc);
        return canvas;
    }


    private void drawSinus(GraphicsContext gc)
    {
        double height = 50;
        double xFactor = 0.5;
        double yFactor = 50;
        for (int index = 0; index < 720; index++)
        {
            double x = index * xFactor;
            double y = Math.sin(Math.toRadians(index)) * yFactor + height;
            if (index == 0)
            {
                gc.moveTo(x, y);
            }
            else
            {
                gc.lineTo(x, y);
            }
        }
        gc.stroke();
    }
}

NEW Graphics2D example

public class Graphics2DDraw extends Application
{
    private static final int PANEL_WIDTH = 400, PANEL_HEIGHT = 100;


    public static void main(String[] args)
    {
        launch(args);
    }


    @Override
    public void start(Stage stage)
    {
        stage.setTitle("Graphics2DDraw");
        StackPane root = new StackPane();
        Scene scene = new Scene(root);
        root.getChildren().add(createImageView());
        stage.setScene(scene);
        stage.show();
    }


    private ImageView createImageView()
    {
        BufferedImage bi = new BufferedImage(PANEL_WIDTH, PANEL_HEIGHT, BufferedImage.TYPE_INT_ARGB);
        Graphics2D g = bi.createGraphics();
        g.setColor(Color.BLACK);
        BasicStroke bs = new BasicStroke(1f, BasicStroke.CAP_ROUND, BasicStroke.JOIN_ROUND);
        g.setStroke(bs);
        g.setRenderingHint(RenderingHints.KEY_ANTIALIASING, RenderingHints.VALUE_ANTIALIAS_ON);
        g.setRenderingHint(RenderingHints.KEY_RENDERING, RenderingHints.VALUE_RENDER_SPEED);
        g.setRenderingHint(RenderingHints.KEY_STROKE_CONTROL, RenderingHints.VALUE_STROKE_PURE);
        drawSinus(g);
        return new ImageView(SwingFXUtils.toFXImage(bi, null));
    }


    private void drawSinus(Graphics2D g)
    {
        double height = 50;
        double xFactor = 0.5;
        double yFactor = 50;
        int length = 720;
        int lastX = 0;
        int lastY = 0;
        GeneralPath path = new GeneralPath();
        for (int index = 0; index < length; index++)
        {
            double x3 = index * xFactor;
            double y3 = Math.sin(Math.toRadians(index)) * yFactor + height;
            if (index == 0)
            {
                path.moveTo(x3, y3);
            }
            else
            {
                path.lineTo(x3, y3);
            }
        }
        g.draw(path);
        g.dispose();
    }
}

EDIT this is what the buffer overflow exception looks like:

java.nio.BufferOverflowException
    at com.sun.javafx.sg.prism.GrowableDataBuffer.ensureReadCapacity(GrowableDataBuffer.java:317)
    at com.sun.javafx.sg.prism.GrowableDataBuffer.getInt(GrowableDataBuffer.java:527)
    at com.sun.javafx.sg.prism.GrowableDataBuffer.getFloat(GrowableDataBuffer.java:563)
    at com.sun.javafx.sg.prism.NGCanvas.renderStream(NGCanvas.java:960)
    at com.sun.javafx.sg.prism.NGCanvas.renderContent(NGCanvas.java:609)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.tk.quantum.ViewPainter.doPaint(ViewPainter.java:477)
    at com.sun.javafx.tk.quantum.ViewPainter.paintImpl(ViewPainter.java:330)
    at com.sun.javafx.tk.quantum.UploadingPainter.run(UploadingPainter.java:134)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
    at com.sun.javafx.tk.RenderJob.run(RenderJob.java:58)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:125)
    at java.lang.Thread.run(Thread.java:748)
java.lang.IllegalArgumentException: ALPHA color component is out of range
    at com.sun.pisces.PiscesRenderer.checkColorRange(PiscesRenderer.java:113)
    at com.sun.pisces.PiscesRenderer.setColor(PiscesRenderer.java:105)
    at com.sun.prism.sw.SWPaint.setColor(SWPaint.java:76)
    at com.sun.prism.sw.SWPaint.setPaintBeforeDraw(SWPaint.java:118)
    at com.sun.prism.sw.SWPaint.setPaintFromShape(SWPaint.java:86)
    at com.sun.prism.sw.SWGraphics.paintShape(SWGraphics.java:493)
    at com.sun.prism.sw.SWGraphics.drawLine(SWGraphics.java:545)
    at com.sun.javafx.sg.prism.NGCanvas.handleRenderOp(NGCanvas.java:1219)
    at com.sun.javafx.sg.prism.NGCanvas.renderStream(NGCanvas.java:1103)
    at com.sun.javafx.sg.prism.NGCanvas.renderContent(NGCanvas.java:609)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:235)
    at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:577)
    at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:2053)
    at com.sun.javafx.sg.prism.NGNode.render(NGNode.java:1945)
    at com.sun.javafx.tk.quantum.ViewPainter.doPaint(ViewPainter.java:477)
    at com.sun.javafx.tk.quantum.ViewPainter.paintImpl(ViewPainter.java:330)
    at com.sun.javafx.tk.quantum.UploadingPainter.run(UploadingPainter.java:134)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
    at com.sun.javafx.tk.RenderJob.run(RenderJob.java:58)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:125)
    at java.lang.Thread.run(Thread.java:748)

EDIT 2: I found a way to improve the quality of the graphics2d drawing. By setting the rendering hints (thank you Hylian Pickachu for the advice) for the graphics2d object, the sine curve looks smoother. It's not as sharp as the sine curve in the canvas example, but I think I can live with the result now.

Hylian Pikachu :

One way to improve Graphics2D quality is by using RenderingHints. RenderingHints allow you to set the balance of rendering quality vs. rendering performance, which is a trade-off to consider, as you said that you did enjoy the performance boost from using Graphics2D over the Canvas. However, this approach will allow you to continue using Graphics2D and avoid crashes.

Guess you like

Origin http://10.200.1.11:23101/article/api/json?id=414987&siteId=1