hate bad code smell

private void for_If(int docCount,WorkFlowEngineAdministration wfeat){
		if (docCount > 0) {
			recordCount = docCount + "";
			PagingTool pt = new PagingTool(Integer.parseInt(recordCount),
					Constants.DEFAULT_PAGE_SIZE);
			pageCount = pt.getLastPageNo() + 1 + "";
			if (pageIndex != null && !pageIndex.equals("")) {
				recordStartLine = pt.getStartLine(Integer
						.parseInt(pageIndex) - 1)
						+ "";
			} else {
				pageIndex = "1";
				recordStartLine = pt.getStartLine(0) + "";
			}
			recordEndLine = pt.getEndLine(Integer.parseInt(pageIndex) - 1)
					+ "";

			recordList = wfeat.findFlowInstancesByIsFinished(false,
					docTypeId, orderBy, orderType, Integer
							.parseInt(recordStartLine),
					Constants.DEFAULT_PAGE_SIZE);
			if (recordEndLine.equals("-1")) {
				recordStartLine = "0";
				recordEndLine = "0";
			} else {
				recordStartLine = Integer.parseInt(recordStartLine) + 1
						+ "";
			}
		}
	}
	
	private void for_ElseIf(int docCount,WorkFlowEngineAdministration wfeat){
		if (docCount > 0) {
			recordCount = docCount + "";
			PagingTool pt = new PagingTool(Integer.parseInt(recordCount),
					Constants.DEFAULT_PAGE_SIZE);
			pageCount = pt.getLastPageNo() + 1 + "";
			if (pageIndex != null && !pageIndex.equals("")) {
				recordStartLine = pt.getStartLine(Integer
						.parseInt(pageIndex) - 1)
						+ "";
			} else {
				pageIndex = "1";
				recordStartLine = pt.getStartLine(0) + "";
			}
			recordEndLine = pt.getEndLine(Integer.parseInt(pageIndex) - 1)
					+ "";

			recordList = wfeat.findFlowInstancesByHasTimer(true, docTypeId,
					orderBy, orderType, Integer.parseInt(recordStartLine),
					Constants.DEFAULT_PAGE_SIZE);
			if (recordEndLine.equals("-1")) {
				recordStartLine = "0";
				recordEndLine = "0";
			} else {
				recordStartLine = Integer.parseInt(recordStartLine) + 1
						+ "";
			}
		}
		
	}
	
	
	private void ifElse(int docCount,WorkFlowEngineAdministration wfeat){
		if (docCount > 0) {
			recordCount = docCount + "";
			PagingTool pt = new PagingTool(Integer.parseInt(recordCount),
					Constants.DEFAULT_PAGE_SIZE);
			pageCount = pt.getLastPageNo() + 1 + "";
			if (pageIndex != null && !pageIndex.equals("")) {
				recordStartLine = pt.getStartLine(Integer
						.parseInt(pageIndex) - 1)
						+ "";

			} else {
				pageIndex = "1";
				recordStartLine = pt.getStartLine(0) + "";

			}
			recordEndLine = pt.getEndLine(Integer.parseInt(pageIndex) - 1)
					+ "";

			recordList = wfeat.findFlowInstancesByIsFinished(true,
					docTypeId, orderBy, orderType, Integer
							.parseInt(recordStartLine),
					Constants.DEFAULT_PAGE_SIZE);
			if (recordEndLine.equals("-1")) {
				recordStartLine = "0";
				recordEndLine = "0";
			} else {
				recordStartLine = Integer.parseInt(recordStartLine) + 1
						+ "";
			}
		}
		
	}

 

Guess you like

Origin http://10.200.1.11:23101/article/api/json?id=326948464&siteId=291194637