The return value of "orElseThrow" must be used

Baji Shaik :

When I am scanning code with sonar lint the following code shows the bug as "The return value of "orElseThrow" must be used"

itemList.stream()
    .filter(item -> orderItemId.equals(item.getId()))
    .findAny()
    .orElseThrow(() -> new BadRequestException("12345","Item Not Found"));

This is just for a validation purpose no need to return anything from this statement. need to validate whether the item exists or not.

FYI: Eclipse showing a quick fix as squid:S2201

Anybody have any idea how to resolve this bug?

Eran :

I'm assuming this is a warning (not using the value returned by orElseThrow() shouldn't be an error).

If you wish to eliminate that warning, use isPresent() instead:

if (!itemList.stream().filter(i->orderItemId.equals(i.getId())).findAny().isPresent()) {
    throw new BadRequestException("12345","Item Not Found");
}

or just avoid using Optionals, and use anyMatch() instead:

if (!itemList.stream().anyMatch(i->orderItemId.equals(i.getId()))) {
    throw new BadRequestException("12345","Item Not Found");
}

Guess you like

Origin http://10.200.1.11:23101/article/api/json?id=436172&siteId=1

The return value of "orElseThrow" must be used

Be careful, the return value of the function you must control!

Refactor orElseThrow block to return RuntimeException

Unable to understand when a return statement must be used in association with recursion

Build Pattern Intellij warning: Return value of the method is never used

return value of return

ajax return value return value

Java 8 optional: ifPresent return object orElseThrow exception

Invalid default value for prop "value": Props with type Object/Array must use a factory function to return the default value.

This import is never used as a value, "import type" must be used because "importsNotUsedAsValues" is set to "error".

Note that when writing a select query in mybatis, you must write the return value in xml

Binary search tree and doubly linked list (almost, recursion must write return value)

【Python】Function ④ (function None return value | None value application scenario | used for if judgment | define variable without initial content | code example )

Laravel return value

Callable interface return value

strchr return value

mybatis update the return value

Parameter and return value

The return value update mybatis

Function return value is a function

Finally on the impact of the return value

net core return value

Return value filter output

Carefully return value lseek

springboot return value

The return value of the function and scope

js return value generator

Gets bat return value

The return value in response SpringMVC

mvc view the return value