Is it a bad practice to throw exceptions in java 8 optional filters

user3495691 :

I wanted to leverage java 8 optional to validate values of the an object received (as a response). I'm curious to know, if it is a bad practice to do as below.

Optional.ofNullable(response)
.map(Response::getStatus)
.filter(status -> {
    if (status == Status.REJECTED)
        throw new RequestRejectedException("some exception");
    else if (status == Status.LOCKED)
        throw new ResourceLockedException("some other exception");
    return true;
})
.orElse(Status.UNAVAILABLE);

Wanted to know, if this is acceptable to write something like above or if there is a better way to do it, please suggest.

Andrew Tobilko :

No, it's not OK.

return true;

You don't filter anything, do you? It would be better to handle exceptions after the status is known.

final String status = Optional.ofNullable(response)
                              .map(Response::getStatus)
                              .orElse(Status.UNAVAILABLE);

if ("rejected".equals(status)) {
    throw new RequestRejectedException("some exception");
}

Judging from your comment, you seem to understand what Optional is for. No need to warn you it's an inappropriate usage.

Guess you like

Origin http://43.154.161.224:23101/article/api/json?id=309581&siteId=1

Is it a bad practice to throw exceptions in java 8 optional filters

Java exceptions wrapping: bad practice?

Throw exception in optional in Java8

[Log] Java8 optional, single operation, repeated practice

Best Practice: Using Java 8 Optional or throwing Exception

java key mechanism for handling exceptions and throw throws

Overview of the practice of using Java Optional

Java8-Optional

Java 8 Optional instead of if

Java 8 Optional

java 8 stream multiple filters

--- Optional use of java8

java8 Optional packaging

Java 8 Optional Best Guide

The signature of flatMap in Optional of Java 8

Java bad practice doing: new... ().doSomething()?

Inner class for listener in Java, is this bad practice?

Q: Is embedding Java bad practice in BPEL?

How to throw an Exception in a Consumer Java 8

How to throw an Exception in a Consumer Java 8

How to throw an Exception in a Consumer Java 8

How to throw an Exception in a Consumer Java 8

Java throw: throw an exception

How does this work - Java 8 Optional.of and Optional.ofNullable

Defaulting Optional orElse with Optional.empty in Java 8

Throw checked exceptions are multiple methods

Subclass throw checked exceptions restrictions

Optional base class used in Java8

Java 8 Optional: gracefully avoid NPE

[Optional] Detailed new features java8