Simple instructions for using Gerrit

Code submission requirements

  1. A Commit corresponds to a modification point (unless it is in the initial stage of the project or when upgrading the BSP).
  2. Do not arbitrarily modify the properties of the file. The file attribute modified by Windows will become 755. When uploading the code, please pay attention to modify it to the original attribute of the file. You can use git whatchanged to view the file modified by your commit.
  3. The indentation format is the same as the original file.
  4. Do not modify code unrelated to the submission.

Git commit comment requirements

  1. To set GIT to use vim to edit commits, please do not use the -m parameter (git config –global core.editor vim).
  2. Notes should be written in English.
  3. If the code is for a project change, start with the project name+:+space, for example D508: Add software navigator bar.
  4. Roughly write down what the modification is on the first line, please note that it should not be too long.
  5. After the blank line, write in detail what was modified and why it was modified. If it is related to a bug, please write the bug number.

example:

S100D: Cofigure GPIO31 and GPIO33 to INPUT PULL UP.

OEMSBL would check VOL+ and VOL- to enter download mode,
becase we only checked the low status, so we need set these two
GPIO to input pull up, otherwise, we can't get right status.

code uploader

  1. Modify the code and submit it to Gerrit after verification .
  2. After the code is submitted, log in to Gerrit and check the code by yourself (focus on whether the indentation format is consistent with the original file; remove the red space part; whether the modified content is correct; whether the naming is meaningful; whether the comment content meets the requirements, etc.).
  3. After checking for yourself, click the "Review" button, +1 in "Verified", +1 in "Code Review", and click "Publish Comments".
  4. In the "Reviewer" column, add the reviewer.
  5. If the code review fails, repeat steps 1, 2, and 3.

Inspector

  1. After receiving the email notification, log in to Gerrit and review the code.
  2. If the review is approved, click the "Review" button, +1 in "Verified", +2 in "Code Review", and click "Publish Comments".
  3. If the code review does not pass, click the "Review" button, in "Code Review" -2, after writing the comment, click "Publish Comments".

Guess you like

Origin http://43.154.161.224:23101/article/api/json?id=324725497&siteId=291194637