Java beginner here getting non zero numbers

Elo :

I just want to ask why the temp in my method NonZeros does not change its elements even though I explicitly assign each element of temp whenever the source has a nonzero element. Here's my work.

package nonzeros;
public class NonZeros {
    public static void main(String[] args) {
        int [] B = {0,1,2,3,2};
        int [] newone = NonZeros(B);
        for(int q = 0; q < newone.length; q++){
            System.out.println(newone[q]);
        }
    }
    public static int[] NonZeros(int [] A){
        int [] temp = new int[4];
        for(int i = 0; i < A.length;i++){
            if(A[i] != 0){
                int j = 0;
                temp[j] = A[i];
                j++;
            }
        }
        return temp;
    }
}

Here's the result: run: 2 0 0 0

However, the result should be: 1 2 3 2

Elliott Frisch :

Step one, count the non zero values. Step two, create the new array. Step three, fill it with non-zero values like

public static int[] NonZeros(int[] A) {
    int count = 0;
    for (int i = 0; i < A.length; i++) {
        if (A[i] != 0) {
            count++;
        }
    }
    int[] temp = new int[count];
    int p = 0;
    for (int i = 0; i < A.length; i++) {
        if (A[i] != 0) {
            temp[p++] = A[i];
        }
    }
    return temp;
}

Alternatively, use a lambda and filter like

public static int[] NonZeros(int[] A) {
    return Arrays.stream(A).filter(i -> i != 0).toArray();
}

Guess you like

Origin http://43.154.161.224:23101/article/api/json?id=135207&siteId=1