code standard

通用:
------------------------------------------------------------------------------------

1、类命名建议:
AccountDao
AccountDto
AccountStatusEnum
2、
方法名命名格式:单词第一个字母大写,但首字母小写
类命名:单词第一个字母大写
类实例:尽量与类实例保持一致,但首字母小写

3、加上TODO,以便于后续处理
比如这种:resp.setName("测试企业名称");

4、乐观锁的使用 version=#version#
这样写是有问题的:
investRequestResp.setVersion(investRequestResp.getVersion()+1);
investRequestService.updateInversRequestInfoById(investRequestResp);
建议的写法:update xxx set version = #version#+1 where xx=#xx# and version = #version#


5、不需要,sql语句中也不需要写
investRequest.setCreateTime(new Date());
investRequest.setModifyTime(new Date());

Trading:
------------------------------------------------------------------------------------
1、InvestRequestDto中的accountId是自己系统的,不需要转换为String

2、关于查询,一定要注意:确保你的查询走确定的索引
下面这个例子会用到很多字段,不会走正确的索引
//初始化申购申请表
InvestRequestDtoinvestRequest=newInvestRequestDto();
investRequest.setMemberId(req.getMemberId());
investRequest.setOrderId(req.getOrderId());
investRequest.setProductId(req.getProductId());
investRequest.setInvestAmount(req.getAmount());
investRequest.setAccountId(accountIdStr);
investRequest.setSalesChannelNo(req.getSalesChannel());
investRequest.setUserType(req.getUserType());
investRequest.setTradeBizCode(TradeBizCodeEnum.INVESTREQUEST.getCode());
investRequest.setStatus(InvestRequestStatusEnum.LOAD.getCode());
if(!StringUtils.isNullOrEmpty(req.getTrdTime())){
investRequest.setTrdTime(formatterT.parse(req.getTrdTime()));
}
if(!StringUtils.isNullOrEmpty(req.getTrdDate())){
investRequest.setTrdDate(formatterD.parse(req.getTrdDate()));
}
//操作记录
investRequest.setCreateBy(CommonConstants.TRADE_OPERATE_SYSTEM);
investRequest.setCreateTime(newDate());
investRequest.setModifyBy(CommonConstants.TRADE_OPERATE_SYSTEM);
investRequest.setModifyTime(newDate());
investRequestService.insertInvestRequestInfo(investRequest);
InvestRequestDtoinvestRequestResp=newInvestRequestDto();

//TODO这个查询有问题,不会走索引
investRequestResp=investRequestService.queryInvestRequestInfo(investRequest);

猜你喜欢

转载自rainworlder.iteye.com/blog/2347508